Skip to content

Fix handling duplicated parameters when array#820

Merged
adityapatwardhan merged 8 commits into
PowerShell:mainfrom
Gijsreyn:gh-789/main/handle-duplicated-parameters
Jul 8, 2026
Merged

Fix handling duplicated parameters when array#820
adityapatwardhan merged 8 commits into
PowerShell:mainfrom
Gijsreyn:gh-789/main/handle-duplicated-parameters

Conversation

@Gijsreyn

@Gijsreyn Gijsreyn commented Sep 10, 2025

Copy link
Copy Markdown
Contributor

PR Summary

This pull request addresses the issue when generating pipeline parameters of type array; duplicate input types were created in the output Markdown. It fixed type name handling to maintain array semantics for input/output types and preserves array notation when parsing Markdown.

PR Context

Fix #789


This change is Reviewable

sdwheeler
sdwheeler previously approved these changes Jul 6, 2026

@sdwheeler sdwheeler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@adityapatwardhan

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@adityapatwardhan adityapatwardhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of changes to use the StringBuilderPool

Comment thread src/MarkdownReader/CommandHelpMarkdownReader.cs Outdated
Comment thread src/MarkdownReader/CommandHelpMarkdownReader.cs Outdated
@adityapatwardhan

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@adityapatwardhan

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@sdwheeler sdwheeler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@adityapatwardhan

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@adityapatwardhan adityapatwardhan merged commit 135ffd5 into PowerShell:main Jul 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inputs duplicated for parameters with ValueFromPipeline and array

3 participants